search

jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

Move the step names to constants and introduce a constant for the first step #604

Closed claudep closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #604 (f39abc5) into master (6817d28) will decrease coverage by 0.15%. The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   95.56%   95.42%   -0.15%     
==========================================
  Files          74       74              
  Lines        3182     3191       +9     
  Branches      358      358              
==========================================
+ Hits         3041     3045       +4     
- Misses        112      117       +5     
  Partials       29       29
Impacted Files Coverage Δ
two_factor/views/core.py 96.65% <93.75%> (+0.03%) :arrow_up:
two_factor/plugins/webauthn/tests/test_e2e.py 42.68% <0.00%> (-2.78%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

claudep commented 1 year ago

Thanks @peymanslh for your approval. I think I'd rather commit first #588 (if you could review it) and release 1.15.1, then merge this one.