jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

avoid multiple registrations of the same method #658

Closed jpaniagualaconich closed 1 year ago

jpaniagualaconich commented 1 year ago

Fixes #657

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #658 (f11ba39) into master (d6d8b63) will increase coverage by 0.05%. Report is 2 commits behind head on master. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   95.44%   95.50%   +0.05%     
==========================================
  Files          76       77       +1     
  Lines        3293     3335      +42     
  Branches      377      379       +2     
==========================================
+ Hits         3143     3185      +42     
  Misses        119      119              
  Partials       31       31              
Files Changed Coverage Δ
tests/test_registry.py 100.00% <100.00%> (ø)
two_factor/plugins/registry.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

claudep commented 1 year ago

Once again, it would be great to add a small regression test.

jpaniagualaconich commented 1 year ago

@claudep added tests/test_registry.py