jazzband / django-two-factor-auth

Complete Two-Factor Authentication for Django providing the easiest integration into most Django projects.
MIT License
1.71k stars 448 forks source link

make PhoneBaseMethod.get_devices retrieve all phone devices of the user #660

Closed jpaniagualaconich closed 1 year ago

jpaniagualaconich commented 1 year ago

Fixes #659

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 1 year ago

Codecov Report

Merging #660 (8db3d58) into master (d6d8b63) will increase coverage by 0.03%. Report is 3 commits behind head on master. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
+ Coverage   95.44%   95.47%   +0.03%     
==========================================
  Files          76       77       +1     
  Lines        3293     3317      +24     
  Branches      377      375       -2     
==========================================
+ Hits         3143     3167      +24     
  Misses        119      119              
  Partials       31       31              
Files Changed Coverage Δ
two_factor/plugins/phonenumber/method.py 100.00% <100.00%> (ø)
...wo_factor/plugins/phonenumber/tests/test_method.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

claudep commented 1 year ago

Now you know what my next comment will be :smile:, test, test, test...

jpaniagualaconich commented 1 year ago

@claudep added two_factor/plugins/phonenumber/tests/test_method.py

claudep commented 1 year ago

Minus, the pre-commit failures, but I'm sure they'll get fixed soon!

jpaniagualaconich commented 1 year ago

@claudep they are fixed now