jazzband / jsonmodels

jsonmodels is library to make it easier for you to deal with structures that are converted to, or read from JSON.
http://jsonmodels.readthedocs.org/en/latest/
BSD 3-Clause "New" or "Revised" License
335 stars 51 forks source link

CI: Replace deprecated pypy3 with pypy-3.8 #157

Closed hugovk closed 2 years ago

hugovk commented 2 years ago

pypy3 is deprecated and is not available in newer images: https://github.com/actions/setup-python/issues/244#issuecomment-925966022

Instead explicitly specify the version: https://github.com/actions/setup-python#specifying-a-pypy-version

Committed via https://github.com/asottile/all-repos

TODO

image

codecov[bot] commented 2 years ago

Codecov Report

Merging #157 (6ddc77e) into master (946541f) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          764       764           
  Branches       186       186           
=========================================
  Hits           764       764           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 946541f...6ddc77e. Read the comment docs.

hugovk commented 2 years ago

@beregond Please could you replace this required branch check with build (pypy-3.8)?

image

beregond commented 2 years ago

@hugovk yes, will do

beregond commented 2 years ago

Okay, can't help it myself - @jezdez maybe you can help with this?

hugovk commented 2 years ago

Updated to add a final, noop job to indicate success:

image

Its success depends on the build step fully passing. So instead of needing to adjust the checks each and every time a Python version is added or removed from the matrix, we can just add this new "test successful" as the required check.

@jezdez So please can you remove all the old "build" required checks and add "test successful"?

jezdez commented 2 years ago

@hugovk Done!