Closed chanind closed 1 week ago
Informally tagging @anthonyduong9 as a reviewer
Attention: Patch coverage is 93.33333%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 72.74%. Comparing base (
aa98caf
) to head (4461ccb
). Report is 5 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
sae_lens/training/training_sae.py | 90.00% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR fixes some minor issues related to jumprelu SAEs:
threshold
param and alog_threshold
param onTrainingSAE
, and callingencode()
incorrectly used thethreshold
whileencode_with_hidden_pre
correctly used thelog_threshold
Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and unit tests (acceptance tests not currently in use)
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)