jbloomAus / SAELens

Training Sparse Autoencoders on Language Models
https://jbloomaus.github.io/SAELens/
MIT License
481 stars 127 forks source link

fix: fixing jumprelu encode and save/load #373

Closed chanind closed 1 week ago

chanind commented 1 week ago

Description

This PR fixes some minor issues related to jumprelu SAEs:

Type of change

Please delete options that are not relevant.

Checklist:

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

chanind commented 1 week ago

Informally tagging @anthonyduong9 as a reviewer

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 72.74%. Comparing base (aa98caf) to head (4461ccb). Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
sae_lens/training/training_sae.py 90.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #373 +/- ## ========================================== + Coverage 72.46% 72.74% +0.28% ========================================== Files 22 22 Lines 3258 3266 +8 Branches 431 431 ========================================== + Hits 2361 2376 +15 + Misses 767 762 -5 + Partials 130 128 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.