Closed chanind closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 72.74%. Comparing base (
17506ac
) to head (4f28b21
). Report is 2 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
In #365, we fixed a bug where the
scale_sparsity_penalty_by_decoder_norm
was being ignored and the SAE was always scaling by decoder norm regardless. However, this fix revealed a second bug where we're not passing thescale_sparsity_penalty_by_decoder_norm
param through to the training SAE at all. This sort of bug is easy to happen given that we create theTrainingSAEConfig
from the runner config via creating a dictionary without type checking.This PR adds a test just that
scale_sparsity_penalty_by_decoder_norm
is now being passed through correctly to get this fix out asap, but I'll make a follow-up PR with a more robust fix in the form of better tests or type checking or something after this is merged.Type of change
Please delete options that are not relevant.
Checklist:
You have tested formatting, typing and unit tests (acceptance tests not currently in use)
make check-ci
to check format and linting. (you can runmake format
to format code if needed.)