jbloomAus / SAELens

Training Sparse Autoencoders on Language Models
https://jbloomaus.github.io/SAELens/
MIT License
481 stars 127 forks source link

chore: adding test that all config params pass to sae #379

Closed chanind closed 1 week ago

chanind commented 1 week ago

Description

Following #377, this PR adds tests which iterate over all the properties of cfg.get_training_sae_cfg_dict() and cfg.get_base_sae_cfg_dict() and ensure that there are no properties missing. This should help ensure that more bugs like #377 can't happen in the future.

Type of change

Please delete options that are not relevant.

-[x] chore: tests

Checklist:

You have tested formatting, typing and unit tests (acceptance tests not currently in use)

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 72.74%. Comparing base (38876b4) to head (4b37fa2). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #379 +/- ## ======================================= Coverage 72.74% 72.74% ======================================= Files 22 22 Lines 3266 3266 Branches 431 431 ======================================= Hits 2376 2376 Misses 762 762 Partials 128 128 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.