jborean93 / smbprotocol

Python SMBv2 and v3 Client
MIT License
316 stars 73 forks source link

Raise original BadNetworkName error on DFS failure #204

Closed jborean93 closed 1 year ago

jborean93 commented 1 year ago

When attempting to resolve the DFS path on a BadNetworkName error it may error with a DFS related error message. This error should be ignored if the error was stating DFS is unavailable. The whole check can also be avoided entirely if the server does not indicate it supports DFS in the capabilities it sends back.

Fixes: https://github.com/jborean93/smbprotocol/issues/196

codecov[bot] commented 1 year ago

Codecov Report

Merging #204 (fd6f673) into master (a885356) will decrease coverage by 0.01%. The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   99.09%   99.07%   -0.02%     
==========================================
  Files          24       24              
  Lines        5077     5082       +5     
==========================================
+ Hits         5031     5035       +4     
- Misses         46       47       +1     
Flag Coverage Δ
99.07% <77.77%> (-0.02%) :arrow_down:
py3.10 99.03% <77.77%> (-0.04%) :arrow_down:
py3.11 99.03% <77.77%> (-0.04%) :arrow_down:
py3.7 99.03% <77.77%> (-0.04%) :arrow_down:
py3.8 99.03% <77.77%> (-0.04%) :arrow_down:
py3.9 99.07% <77.77%> (-0.02%) :arrow_down:
x64 99.07% <77.77%> (-0.02%) :arrow_down:
x86 98.99% <77.77%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbclient/_pool.py 95.54% <77.77%> (-0.40%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.