search

jboss-developer / jboss-jdg-quickstarts

Quickstarts (or examples, or samples) for Infinispan.
Apache License 2.0
67 stars 99 forks source link

Add Datagrid/Prometheus/Grafana on Openshift demo #228

Closed vblagoje closed 5 years ago

vblagoje commented 5 years ago

@galderz do not integrate yet as RHDG images are not public yet. This is just a preview for us to run the demo. As soon as we have a public datagrid 7.3 image we can integrate this demo

galderz commented 5 years ago

Hey @vblagoje, as mentioned on Zulip on Monday:

... but they do have a script that allows us to automate testing of the tutorial. This is important to make sure things work as expected

I don't see any test script here that we can execute to verify everything works as expected. We need this to avoid people having to manually test the demo to verify it works. Manual testing won't scale. There are a few test.sh in the openshift tutorial branch that you can use as inspiration.

Also, again, as mentioned on Zulip on Monday, please send the PR against the openshift tutorial branch and store it under openshift/shared. I'm assuming the tutorial is valid regardless of whether you use cache or datagrid service.

vblagoje commented 5 years ago

@galderz apologies for the confusion. As we are not creating Prometheus enabled images for cache or datagrid service yet (see Zulip channel) I can only make a demo for the regular datagrid image, what now?

vblagoje commented 5 years ago

Retiring, a new PR is at https://github.com/jboss-developer/jboss-jdg-quickstarts/pull/247