jbostoen / itop-jb-report-generator

https://jeffreybostoen.be
2 stars 2 forks source link

Limitation: GET method = maximum of 2,048 characters, minus the number of characters in the actual path #15

Open jbostoen opened 8 months ago

jbostoen commented 8 months ago

In the current implementation, a button is shown which is just a link to the Report Generator module.

By default, in browsers and webservers, the GET method is usually restricted to 2,048 characters.

It's similar to a lot of other places in the iTop application.

https://somedomain.org/pages/exec.php?&exec_module=jb-report-generator&exec_page=reporting.php&exec_env=production&view=list&template=userrequest_analysis_plotlyjs.html&type=list&reportdir=jb-report-generator-examples&filter=%255B%2522SELECT%2B%2560UserRequest%2560%2BFROM%2BUserRequest%2BAS%2B%2560UserRequest%2560%2BWHERE%2B1%2522%252C%255B%255D%252C%255B%255D%255D

Default: the whole FQDN, exec_module, exec_page, exec_env.

We're assuming that for nearly every case case, there will be a "filter" as well, which could become very complex and grow a lot.

Then, depending on the report, there may be different parameters as well.

jbostoen commented 8 months ago

To evaluate: We show the button on lists.

Currently, as soon as the search criteria change, the entire list - including buttons - gets regenerated anyway. Can't we set a random session variable; and specify the UID of the session variable name in the URL parameter instead?