Update to RabbitMQ 3.4.0

pma commented 10 years ago

Updated from the mercurial repository, tag "rabbitmq_v3_4_0".

Line 78 of amqp_direct_connection.erl was edited manually to underscore the Node variable name and remove the compiler warning src/amqp_direct_connection.erl:78: Warning: variable 'Node' is unused. I'll report this upstream in case it has not been fixed in master.

This update was tested using the test suite in the Elixir amqp wrapper.

Detail of the changed line:

handle_message({'DOWN', _MRef, process, _ConnSup, Reason},
               State = #state{node = _Node}) ->
    {stop, {remote_node_down, Reason}, State};

pma commented 10 years ago

@jbrisbin ping

Regarding the compilation warning, I sent a patch to also fix it on master: https://groups.google.com/forum/#!searchin/rabbitmq-users/unused$20variable/rabbitmq-users/5EsBb6llPIo/u1crAy7LKZwJ

jbrisbin commented 10 years ago

I did review this and this looks great. Thanks for submitting these. I'll try and get these incorporated today.

jbrisbin commented 10 years ago

@pma thanks for the PR! Do you have a Twitter handle I can mention in my announcement tweet?

pma commented 10 years ago

@jbrisbin I'm sorry but I don't have a Twitter account.

Thanks for merging. I'll update the package in the Elixir package repository: https://hex.pm/packages/amqp_client

jbrisbin / amqp_client

Update to RabbitMQ 3.4.0 #16