search

jbruening / ugui-mvvm

Unity3D uGUI mvvm databinding via the standard IXChanged interfaces used in wpf (INotifyPropertyChanged, INotifyCollectionChanged, etc)
Other
214 stars 41 forks source link

Add autosuggest control for entering property paths #14

Closed AdamMitchell-ms closed 5 years ago

AdamMitchell-ms commented 5 years ago

The autosuggest control supports clicking, scrolling, and keyboard arrows+enter to select an entry. List is animated so it doesn't cause things below to jump around too much in a single frame.

ugui-mvvm-autosuggest2

AdamMitchell-ms commented 5 years ago

Hey @jbruening, Some of these changes target .NET 4.x instead of 3.5. I noticed that @Alex-MSFT already checked in a change that requires .NET 4.x. So for now I've updated the project settings to target 4.x. Is this ok with you? Or do you still want to target 3.5? If so, then I can go back and update this to remove any use of 4.x features.

As of Unity 2017, .NET 3.5 is listed as "stable". As of Unity 2018, .NET 3.5 is listed as "obsolete". I haven't installed Unity 2019, so I don't know what it says there.

AdamMitchell-ms commented 5 years ago

Also @jbruening , would you consider making @ritijain and @Alex-MSFT collaborators as well? They are both coworkers of @ryantrem and I.

AdamMitchell-ms commented 5 years ago

Just realized that I've reverted the label shown for the Property. I'll fix it before merging the PR.

Edit: fixed with latest commit.

AdamMitchell-ms commented 5 years ago

Hey @jbruening , I went ahead and merged it for now. Per my comments above, if you want to support .net 3.5, let me know.