search

jbtule / cdto

Finder Toolbar app to open the current directory in the Terminal
MIT License
2.31k stars 233 forks source link

Updated fork #25

Open ealeksandrov opened 8 years ago

ealeksandrov commented 8 years ago

Hey, everyone interested in this project. Since author don't have time to update this repository and in pull requests I see a lot of valuable contributions - I created a fork and merged most important PRs there (#13, #14, #21, #22), cleaned up code a bit and released latest code-signed binary. Tested on macOS 10.12 Sierra and iTerm2 3.0.10.

Welcome: https://github.com/ealeksandrov/cdto

@jbtule thanks for your project, it is pretty awesome, feel free to merge/cherry-pick some of my commits if you'll decide to update your upstream.

tghs commented 8 years ago

@ealeksandrov Thanks for doing this. 👍

dimitrieh commented 7 years ago

@ealeksandrov thanks for doing this! getting your fork in my brewfile as cask ! awesome stuff

tghs commented 7 years ago

On the cask situation, I've added the fork as the ealeksandrov-cd-to cask as per their policy on packaging forks.

The cd-to cask can be updated to the fork if @jbtule nominates the fork as a successor (e.g. by linking to it in the README.md file).

dimitrieh commented 7 years ago

@ealeksandrov would you be able to write a plugin to use it with https://github.com/zeit/hyper ? :)

ealeksandrov commented 7 years ago

@dimitrieh don't have time yet, but look into https://github.com/ealeksandrov/cdto/blob/master/plugins/iterm/CD2ITerm.m#L16 - try to change this to hyper bundle id. Feel free to submit PR :)

dimitrieh commented 7 years ago

@ealeksandrov see https://github.com/ealeksandrov/cdto/pull/1

dreambottle commented 7 years ago

@ealeksandrov I don't see the "Issues" tab in your fork. Why don't you open it up :)

P.S. Kudos for a macos-style icon

dimitrieh commented 7 years ago

@ealeksandrov and could you adjust the cask recipes to preselect which version of cd_to you want to use? :) (say hyper in my case)

ealeksandrov commented 7 years ago

@dreambottle sure, I don't know why it disappeared. It's there now :) @dimitrieh I haven't touched that casks out there. I think @tghs added them. Let's continue discussing it in https://github.com/ealeksandrov/cdto/issues/2