jc-kynesim / rpi-ffmpeg

FFmpeg work for RPI
Other
111 stars 27 forks source link

per-encoder options and ? your intent to submit changes to ffmpeg developers #38

Open hydra3333 opened 2 years ago

hydra3333 commented 2 years ago

Hello. Newbie alert.

In a week or so I hope to have a patch based on ffmpeg's latest github mirror, which changes the way v4l2m2m per-encoder options are made available, validated and set. It's not at all pretty nor elegant, but seems to work so far.

It will also add a few per-encoder user-settable options which ffmpeg does not currently look for nor set, provided I can ascertain what per-encoder options are exposed by the Pi (a la https://forums.raspberrypi.com/viewtopic.php?p=1981239).

I just saw your git branch https://github.com/jc-kynesim/rpi-ffmpeg/tree/release/4.3/rpi_main here https://forums.raspberrypi.com/viewtopic.php?p=1936219#p1936219 My in-development patch seems like it will be broadly compatible with your branch in that it only makes changes to v4l2_m2m_enc.c and v4l2_m2m.h

So, if I may be so bold ...

My reason for asking is, I am unsure whether to eventually submit a patch to the ffmpeg developers via the ffmpeg-develop mailing list (my guess is it will likely get rejected or remain unreviewed) or give it to you in case you decide to merge a variation of it and then pass on a bulk patch request to the ffmpeg developers.

Cheers.