search

jc01rho-openpilot-BoltEV2019-KoKr / boltpilot

openpilot fork for BoltEV only
https://comma.ai/
MIT License
12 stars 30 forks source link

Requires ACC on latest release #217

Closed andyroo-t closed 1 year ago

andyroo-t commented 1 year ago

콤마3 이슈 외에 제보를 받고있지 않습니다. please post only comma3 issues.

*Describe the bug

Previous release worked great on 2020 Premier. Now pressing set or speed control on wheel gives "enable adaptive cruise to engage". There also is no enable comma pedal setting in the UI.

To Reproduce Steps to reproduce the behavior:

  1. Go to set-
  2. Click on set-
  3. Scroll down to comma screen
  4. See error

**Expected behavior

As in prior release, expect LKAS to function

Additional context Add any other context about the problem here.

jc01rho commented 1 year ago

Thx for report. I will update the procedure to run(which Toggles need in ui settings, or make default set toggles, ... ) Openpilot.

Anywa, this repository still keeps "Previous release" that you've mentioned. Named v0819-c3

And a.. do you installed comma-Pedal?

andyroo-t commented 1 year ago

Thanks!

Sent from my iPhone

On Jul 23, 2023, at 4:38 PM, jc01rho @.***> wrote:

 Thx for report. I will update the procedure to run(which Toggles need in ui settings, or make default set toggles, ... ) Openpilot.

Anywa, this repository still keeps "Previous release" that you've mentioned. Named v0819-c3

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

andyroo-t commented 1 year ago

Will be happy to test - just pop me an email

Sent from my iPhone

On Jul 23, 2023, at 5:58 PM, andy turudic @.***> wrote:

Thanks!

Sent from my iPhone

On Jul 23, 2023, at 4:38 PM, jc01rho @.***> wrote:

 Thx for report. I will update the procedure to run(which Toggles need in ui settings, or make default set toggles, ... ) Openpilot.

Anywa, this repository still keeps "Previous release" that you've mentioned. Named v0819-c3

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

jc01rho commented 1 year ago

Here is settings-Toggle page in comma 3, Written in Korean.

please get a same toggles with my.

20230724_083904.jpg first - "Use Openpilot" Second (last row in picture )- EnableRadarTracks

20230724_083910.jpg First - EnableRadarTracks Second (below EnableRadarTracks in picture ) - Warning at lane departure Third ("미터법 사용" in row) - use metrics Fourth (see the numeric "24" in row ) - ETA in 24h

andyroo-t commented 1 year ago

OK. Thanks.

I did have OpenPilot enabled, but your second screenshot shows many settings I did not.

I'm traveling in an hour, so am reverting to v0819-c3 for now, but will try it out later this week.

Sent from my iPhone

On Jul 23, 2023, at 6:41 PM, jc01rho @.***> wrote:

 Here is settings-Toggle page in comma 3, Written in Korean.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

andyroo-t commented 1 year ago

Hi,

0.0819-c3 Reversion is working again with autosteer on the 2020.

Do you have a test checklist or plan I can do so we can add the '20 as tested?

Sent from my iPhone

On Jul 23, 2023, at 7:00 PM, andy turudic @.***> wrote:

OK. Thanks.

I did have OpenPilot enabled, but your second screenshot shows many settings I did not.

I'm traveling in an hour, so am reverting to v0819-c3 for now, but will try it out later this week.

Sent from my iPhone

On Jul 23, 2023, at 6:41 PM, jc01rho @.***> wrote:

 Here is settings-Toggle page in comma 3, Written in Korean.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

jc01rho commented 1 year ago

before the checklist, please tell me that you are using comma3 without CommaPedal? So only steer.

andyroo-t commented 1 year ago

Hi,

I have a fairly new Comma3.

Pedal Interceptor board

GM harness from Comma.ai

2020 Premier with LKAS, brake alert, and cruise control (no radar).

Steer still works. I prefer "Torque" vs PID.

Visual ACC also now works (it didn't before...would try to run over cars being followed). It's a bit annoying in its conservatism, so am on the fence on its utility with default settings.

Ran it for 100km just now, probably 80km on highway (100km/h) and 20km city, with final leg of 10km climbing 400m elevation with sharp mountain curves that overwhelm it (as they did before).

https://m.youtube.com/watch?v=_E2WvCHFMuM

The lane identifier/tracker works very well, just that the steer is too timid to follow it faithfully.

Fake ACC is also a bit dangerous, even though poor drivers would assume it's safer with longer follow distance. Other cars cut in because of the excessive follow distance, forcing an unexpected regen brake (with brake lights) for following cars to react to (a 100km/h to 80km/h aggressive slowing with nothing visible ahead that would have triggered it), in order to maintain that crazy distance. I would cut it by half to 2/3 of present values. I'm not a typical lay, undisciplined, unskilled American driver, lol.

Anyway, I am very happy to have it back working again with the reversion after a few days of it being dead with the update. I'm city driving to/from school to my mountain home, so will take another try at the new release when I get some time in the next week or two.

Meanwhile, I think a good idea to add the 2020 as "tested", assuming I can check off all items on your "go" list. Can do same on the new release in a week or two.

Thank you for the crazy amount of investigation and work you guys put in on this. I'm an EE, so I understand the effort put into this.

cheers,

andy

ps do you know of any comprehensive CAN bus deciphering documentation for the Bolt EV? I'd like to build some hardware for the inverter and charger/battery at some point. An incomplete list is better than the one I don't have.

Sent from my iPhone

On Jul 23, 2023, at 8:08 PM, jc01rho @.***> wrote:  before the checklist, please tell me that you are using comma3 without CommaPedal? So only steer.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

jc01rho commented 1 year ago

thx for detail review.

Embarrassingly, there is no perfect checklist. But if the speed control and steering control work well, I think that's a test, so we've added BoltEV 2020 to our list of tested vehicles.

The CAN bus deciphering documentation I have does not exist, all CAN stuff is inspired by opgm (https://github.com/opgm/openpilot).

jc01rho commented 1 year ago

BoltEV 2020 added to "Tested" with commit https://github.com/jc01rho-openpilot-BoltEV2019-KoKr/boltpilot/commit/8466f37d4eafbc456503319f32611a38e8e9fcfe

andyroo-t commented 1 year ago

Hi,

I forgot to mention (sorry), imperial units works fine in your fork, so you can remove the metric restriction.

cheers,

-andy

Sent from my iPhone

On Jul 23, 2023, at 10:51 PM, jc01rho @.***> wrote:

 BoltEV 2020 added to "Tested" with commit 8466f37

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.