search

jcabi / jcabi-beanstalk-maven-plugin

Maven Plugin for AWS Elastic Beanstalk
http://beanstalk.jcabi.com/
Other
11 stars 10 forks source link

Solving #31 WarFile: Check and remove this class #34

Closed westonal closed 8 years ago

westonal commented 8 years ago

31 WarFile.java:51-52: Check and remove this class

Remove references to WarFile Move and adjust tests for WarFile into GenericMojoTests Fix bug, missing "s" on ".ebextensions" Delete WarFile and tests

dmarkov commented 8 years ago

@westonized Many thanks, I will find someone to review it before we merge

dmarkov commented 8 years ago

@mkordas please review

mkordas commented 8 years ago

@westonized I'll try to do a review soon

westonal commented 8 years ago

@mkordas Weird stuff going on. I only addressed the too many methods issue. Yet the null pointer has gone away. Locally I saw null pointers, but on different methods. If feels like a threading issue. I did open #36 The repo now is identical to my very first commit on this branch that failed. I.e. 08ebdd29d43b3cd3a647861412527f3e3972a656 is the same as e46f5263dc7f17a9d67ec29f2e851af90e245db9 Everything in between was me chasing ghosts.

mkordas commented 8 years ago

@westonized for #36 I'm afraid we should dig deeper and either reproduce the issue or find a reason of it. In the current state it violates http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html#5-report-when-it-is-broken

mkordas commented 8 years ago

@westonized see my initial review above, I'll continue later

westonal commented 8 years ago

@mkordas which violates that? This pull request or the issue #36? To track it down, is there a way to force builds without commits, that would be how I would usually detect a flakey build process or tests.

mkordas commented 8 years ago

@westonized yes, #36. You need to have open PR to trigger the builds. Then you can run it for every commit or you can keep them rebuilding for one.

westonal commented 8 years ago

@mkordas

Then you can run it for every commit or you can keep them rebuilding for one.

How though? I need to do this because I made a commit, it had a couple of name changes, and now I'm getting aspect NoAspectBound exceptions and different exceptions on travis. I saw these locally, ran again and went away. Something is very flaky here.

Regarding http://www.yegor256.com/2014/11/24/principles-of-bug-tracking.html#5-report-when-it-is-broken not every bug is reproducible 100% of the time, some bugs are intermittent, like this one. Can't ignore it though.

mkordas commented 8 years ago

@westonized thanks, I will check this PR soon

mkordas commented 8 years ago

@westonized

reproducible 100% of the time, some bugs are intermittent

Yes, we can report intermittent bugs, but only if it indicates the source of problem. Just saying that something sometimes doesn't work isn't going to be easy task for the performer.

mkordas commented 8 years ago

@westonized

How though? I

You ask how to rerun the build? You have icon for it in Travis.

mkordas commented 8 years ago

@westonized see my comments above

westonal commented 8 years ago

@mkordas on Travis I just get "This build can't be restarted" when I click that icon. And no such icon in appveyor apparently.

mkordas commented 8 years ago

@westonized right now I see the following failed:

Tests in error: 

  EnvironmentTest.checksReadinessOfEnvironment:108 » NoAspectBound Exception whi...

  ApplicationTest.createsNewEnvironment:140 » NoAspectBound Exception while init...

  OverridingBundleTest.cachesResultOfLocation:100 » NoAspectBound Exception whil...

  OverridingBundleTest.overridesFileInAws:74 » NoAspectBound Exception while ini...

  GenericMojoTest.executesSuccessfully:78 » NoAspectBound Exception while initia...

  ServerCredentialsTest.fetchesCredentialsFromMavenSettings:61 » NoAspectBound E...

  ServerCredentialsTest.throwsWhenServerIsNotDefined »  Unexpected exception, ex...

  OverridingVersionTest.overridesVersionInEbt:75 » NoAspectBound Exception while...

  BundleTest.fixesBrokenNames:52 » NoAspectBound Exception while initializing co...
mkordas commented 8 years ago

@westonized I'm also getting This build can't be restarted message. Google knows nothing about it. Maybe it's a bug in Travis?

mkordas commented 8 years ago

@westonized and yes, I also don't have rebuild button in AppVeyor. But remember that you can make and push empty commits to trigger new builds

westonal commented 8 years ago

@mkordas OK, I pushed an empty and it passed. So can you continue review?

mkordas commented 8 years ago

@westonized I'll check again soon

mkordas commented 8 years ago

@westonized thanks, looks good

mkordas commented 8 years ago

@rultor merge

rultor commented 8 years ago

@rultor merge

@mkordas Thanks for your request. @yegor256 Please confirm this.

mkordas commented 8 years ago

@yegor256 can you review this PR?

mkordas commented 8 years ago

@yegor256 ping

yegor256 commented 8 years ago

@rultor try to merge

rultor commented 8 years ago

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 years ago

@rultor try to merge

@westonized @yegor256 Oops, I failed. You can see the full log here (spent 3min)


Tests in error: 
  EnvironmentTest.checksReadinessOfEnvironment:108 » NullPointer
  OverridingVersionTest.overridesVersionInEbt:76 » NullPointer

Tests run: 20, Failures: 0, Errors: 2, Skipped: 3

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32.597 s
[INFO] Finished at: 2016-06-27T19:05:44+00:00
[INFO] Final Memory: 40M/431M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project jcabi-beanstalk-maven-plugin: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project jcabi-beanstalk-maven-plugin: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
    at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:82)
    at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:195)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:861)
    at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:729)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
    ... 20 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container 07ac51baac723525606a9fabf3690c4051533fcb96e78b405f48575eef99b70b is dead
Mon Jun 27 19:06:30 UTC 2016
mkordas commented 8 years ago

@yegor256 can you try merging again?

yegor256 commented 8 years ago

@rultor try to merge

yegor256 commented 8 years ago

@mkordas I suspect this failure is related to this: https://github.com/jcabi/jcabi-beanstalk-maven-plugin/issues/36

rultor commented 8 years ago

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 8 years ago

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 4min)

mkordas commented 8 years ago

@yegor256 yes, this is it. There are NPEs both on Rultor and Travis, so it should be easy to reproduce. @westonized can you take a look?

dmarkov commented 8 years ago

@mkordas Many thanks! 48 mins were added to your account in Transaction ID 5773adf6c449af3180000334 (task took 142 hours and 55 mins)

review comments (c=33) added as a bonus

+48 added to your rating, current score is: +5980

dmarkov commented 8 years ago

@rultor deploy pls

rultor commented 8 years ago

@rultor deploy pls

@dmarkov OK, I'll try to deploy now. You can check the progress here

rultor commented 8 years ago

@rultor deploy pls

@dmarkov Done! FYI, the full log is here (took me 6min)