search

jcelliott / turnpike

Go implementation of a WAMP (Web Application Messaging Protocol) client and router
MIT License
258 stars 88 forks source link

Add MIT license headers #22

Closed maxekman closed 11 years ago

maxekman commented 11 years ago

I also added a CONTRIBUTORS file.

jcelliott commented 11 years ago

Having the entire license in each file seems very redundant. My understanding is that you only need to have the license included in the project root and it applies to all the source in the project. Maybe we could omit the headers?

maxekman commented 11 years ago

From an aesthetics point of view I agree with you, but it's common practice to add the license header to every source file, as in the example here https://github.com/LeaVerou/cubic-bezier/pull/4. My thinking is that even a stray source file should be protected, in case anything would happen. I always do this for my open source projects.

jcelliott commented 11 years ago

But there are projects that do the opposite. For example jquery doesn't even mention their (MIT) license in any of the source except this file.

What about a compromise that just says what the license is in each file, something like this:

// Copyright (c) 2013 Joshua Elliott and contributors
// Released under the MIT License
// http://opensource.org/licenses/MIT
maxekman commented 11 years ago

Sure, that seems like a good solution! I'll commit changes. Copyright should be on only you, with contributors in a specific file though.

maxekman commented 11 years ago

Ok, ready to merge.