search

jcsteh / osara

OSARA: Open Source Accessibility for the REAPER Application
GNU General Public License v2.0
128 stars 46 forks source link

Add feedback when quantizing items in TCP #1128

Closed ScottChesworth closed 5 months ago

ScottChesworth commented 5 months ago

Anyone know why that check failed instantly? It was saying the branches could be merged before I opened the PR.

jcsteh commented 5 months ago

I have absolutely no idea. I think AppVeyor is on acid.

ScottChesworth commented 5 months ago

Where does it get that from? Asking for a friend...

jcsteh commented 5 months ago

That said, I'm surprised this built for you locally. It won't build here because of the declaration in the header file.

ScottChesworth commented 5 months ago

What did I do wrong in there? Weird, it builds fine here.

jcsteh commented 5 months ago

In header files, we don't (and can't) have "using namespace std", so you have to prefix anything in the std namespace; e.g. std::string. I really don't understand why this built for you and not me. Very odd.

AppVeyorBot commented 5 months ago

Build succeeded! Build osara pr1128-1565,480a3551 completed (commit https://github.com/jcsteh/osara/commit/480a355195 by @jcsteh) Downloads:

Windows - [installer/osara_pr1128-1565,480a3551.exe](https://ci.appveyor.com/api/buildjobs/94vpg64w0k3cl7bl/artifacts/installer/osara_pr1128-1565,480a3551.exe) - [locale/osara_pr1128-1565,480a3551.pot](https://ci.appveyor.com/api/buildjobs/94vpg64w0k3cl7bl/artifacts/locale/osara_pr1128-1565,480a3551.pot)
Mac - [installer/osara_pr1128-1565,480a3551.dmg](https://ci.appveyor.com/api/buildjobs/skhgfusbqbgm5ie5/artifacts/installer/osara_pr1128-1565,480a3551.dmg)