search

jcwillox / hass-auto-backup

🗃️ Improved Backup Service for Home Assistant that can Automatically Remove Backups and Supports Generational Backup Schemes.
https://jcwillox.github.io/hass-auto-backup
MIT License
368 stars 27 forks source link

Fix async. #11

Closed balloob closed 4 years ago

balloob commented 4 years ago

This fixes 2 async calls in your setup.

However,

This integration is currently preventing the supervisor tab from showing up. Not only does this needs to be fixed, but it needs to also be rolled out to everyone. I don't see that being possible with the current HACS infrastructure.

I am going to block this integration for 107. It can be unblocked for 108 if we know that it will no longer break the supervisor.

jcwillox commented 4 years ago

Thanks, I'm actually in the progress of finalising an update that fixes and actually removes the hassio dependency, it should be available in the next 30 minutes. Embarrassing I also noticed that the call is_connected was doing nothing last night 🤦‍♂.

As you've seen in issue #10 the solution was to add hassio to after_dependencies, which doesn't make sense if it's already a required dependency? This was likely caused by the recent change adding panel_custom to the hassio components after_dependencies.

I'd also mention that while they lose access to the supervisor panel, they still have access to the community store and add-ons. Users will be able to update within the 30-minute scan interval or when they restart. So even if they update to 0.107.0 they will still be able to update AutoBackup.