search

jdauphant / ansible-role-nginx

Ansible role to install and manage nginx configuration
655 stars 302 forks source link

Compatibility with Fedora #152

Closed exploide closed 7 years ago

exploide commented 7 years ago

In meta.yml this role claims to be compatible with Fedora. This is not the case because recent versions of Fedora use dnf instead of yum for package management. This PR makes this role compatible again by using the general package module.

While doing this changes, I thought that the whole set of installation tasks could be simplified by utilizing the package module and the fact that the package name is almost always just nginx on all platforms. But I leave this up to you to decide if a cleanup is reasonable.

jdauphant commented 7 years ago

@exploide Thanks ! We can cleanup,i won't say no for less code for the same features :)