search

jdauphant / ansible-role-nginx

Ansible role to install and manage nginx configuration
655 stars 302 forks source link

Removed keepalive_timeout and types_hash_max_size #185

Closed corford closed 7 years ago

corford commented 7 years ago

keepalive_timeout and types_hash_max_size are performance related settings and it should be left to the admin to decide what their values should be if they are not happy with nginx's built-in defaults (which are already quite sensible). Defining these in vars/main.yml causes more pain because it makes it hard to override (the only way is by passing in a new version of nginx_http_default_params as a role var or on the command line, which is a strange place to do it given these are supposed to be generic defaults),

Example: I prefer keepalive_timeout 30 30 for all of my hosts but currently have to define this in every nginx_sites entry because I can't set it once via an include using nginx_configs (nginx will complain of a duplicate setting and refuse to start).

corford commented 7 years ago

It's also confusing (at least to me) that keepalive_timeout is specified in nginx_http_default_params yet keepalive_requests is not (because if you are tweaking one of these you are almost always going to be tweaking the other one too).

jdauphant commented 7 years ago

Make sense :+1: Thanks @corford