jdauphant / ansible-role-nginx

Ansible role to install and manage nginx configuration

655 stars 302 forks source link

Upgrade to ansible 2.4 #188

Closed rhpvorderman closed 6 years ago

rhpvorderman commented 7 years ago

186

jdauphant commented 7 years ago

@rhpvorderman Thanks, the PR is very good. You have sense of details, I love that ;)

I was thinking maybe we can wait the release of Ansible 2.5 before merging it so the project version will cover both version (I have seen some problems previously where people have to use previous version because of bugs or missing feature). What do you thing?

rhpvorderman commented 7 years ago

Sure. No need to rush the upgrade. Most people will not have updated their ansible yet. And include: still works. This pull request only fixes a deprecation warning on 2.4 and later. It is all up to you when you want to get rid of those warnings ;-).

nogweii commented 6 years ago

Ansible 2.5 has been released, time to merge this?

jdauphant commented 6 years ago

@evaryont Yep !