search

jdereg / json-io

Convert Java to JSON. Convert JSON to Java. Pretty print JSON. Java JSON serializer. Deep copy Java object graphs.
Apache License 2.0
331 stars 116 forks source link

Shouldn't com.cedarsoftware.io.Resolver#createJavaFromJson be public? #304

Open hugebdu opened 1 day ago

hugebdu commented 1 day ago

Code examples do use that method however it is package private.

jdereg commented 1 day ago

You are correct. I added the missing keyword 'public' back to that method. It is there in the origin/master branch. I am planning on releasing with all of these new changes and new tests soon. Significant support added for rootType conversions.

On Thu, Nov 28, 2024 at 8:58 AM Daniel Shmuglin @.***> wrote:

Code examples do use that method https://github.com/jdereg/json-io/blob/master/src/test/java/com/cedarsoftware/io/CustomJsonSubObjectsTest.java#L64 however it is package private.

— Reply to this email directly, view it on GitHub https://github.com/jdereg/json-io/issues/304, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABI76TX2DPIVDHCGZWJKJOL2C4OSDAVCNFSM6AAAAABSVGRMG2VHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YDEMRVHA4DONQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>