search

jdf2e / nutui-react

京东风格的移动端 React 组件库 、支持多端小程序(A React UI Toolkit for Mobile Web)
https://nutui.jd.com/react/
919 stars 263 forks source link

feat(popup): lockscroll 增加可选值 strict, 用于支持 iOS12 #2629

Closed oasis-cloud closed 1 month ago

oasis-cloud commented 1 month ago

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

Summary by CodeRabbit

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.99%. Comparing base (46abf45) to head (40d922f). Report is 4 commits behind head on next.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #2629 +/- ## ========================================== + Coverage 82.92% 82.99% +0.06% ========================================== Files 219 219 Lines 17912 17914 +2 Branches 2544 2549 +5 ========================================== + Hits 14854 14867 +13 + Misses 3053 3042 -11 Partials 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coderabbitai[bot] commented 1 month ago

Walkthrough

此次更改涉及Overlay和Popup组件的多个修改。在Overlay中，OverlayProps接口的lockScroll属性类型更新为boolean | 'strict'，并初始化为true以保持向后兼容。引入了新变量shouldLockScroll来优化锁定滚动的逻辑。在Popup中，导入语句的顺序进行了调整，defaultProps现在包含defaultOverlayProps的扩展，锁定滚动的逻辑也使用了shouldLockScroll，增强了代码的清晰度。文档也相应更新以反映这些变化。

Changes

文件路径 更改摘要
src/packages/overlay/overlay.tsx 更新OverlayProps中的lockScroll属性类型为boolean | 'strict'，引入shouldLockScroll变量以优化锁定滚动逻辑。
src/packages/popup/popup.tsx 调整导入语句顺序，defaultProps现在包含defaultOverlayProps的扩展，更新锁定滚动逻辑以使用shouldLockScroll。
src/packages/overlay/doc.en-US.md 更新文档以反映lockScroll属性类型的变化。
src/packages/overlay/doc.md 更新文档以反映lockScroll属性类型的变化。
src/packages/overlay/doc.zh-TW.md 更新文档以反映lockScroll属性类型的变化。
src/packages/popup/doc.en-US.md 更新文档以反映lockScroll属性类型的变化。
src/packages/popup/doc.md 更新文档以反映lockScroll属性类型的变化。
src/packages/popup/doc.zh-TW.md 更新文档以反映lockScroll属性类型的变化。

Possibly related PRs

Poem

在兔子洞里跳跃欢，
新组件如春花般。
滚动锁定更灵活，
代码清晰乐无边。
让我们一起庆祝吧，
兔子舞动乐无穷！ 🐰✨

📜 Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
📥 Commits Files that changed from the base of the PR and between fdde0519b37107c9d8e3f472a3ce34edbd85f353 and 40d922f0a9fb810c645751937f95354ad60a6ed3.
📒 Files selected for processing (6) * src/packages/overlay/doc.en-US.md (1 hunks) * src/packages/overlay/doc.md (1 hunks) * src/packages/overlay/doc.zh-TW.md (1 hunks) * src/packages/popup/doc.en-US.md (1 hunks) * src/packages/popup/doc.md (1 hunks) * src/packages/popup/doc.zh-TW.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (6) * src/packages/overlay/doc.en-US.md * src/packages/overlay/doc.md * src/packages/overlay/doc.zh-TW.md * src/packages/popup/doc.en-US.md * src/packages/popup/doc.md * src/packages/popup/doc.zh-TW.md
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > ‼️ **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
xiaoyatong commented 1 month ago

需要补充一下文档