Uses `Version` class to solve version mismatch

jdhitsolutions / WingetTools

A set of PowerShell tools for working with the winget package manager.

MIT License

146 stars 14 forks source link

Uses `Version` class to solve version mismatch #21

Closed zbalkan closed 9 months ago

zbalkan commented 1 year ago

Solves https://github.com/jdhitsolutions/WingetTools/issues/20 but adds a performance penalty due to casting and comparison.

jdhitsolutions commented 1 year ago

I originally had similar code using [version] but it fails when encountering version strings like 1.2.0.1165.gabf054ab , v1.17.2, or 3.3.1+06924 which is why I reverted to plain text.

zbalkan commented 1 year ago

Thank you for the information. So, is it better to close the PR or to get some fancy Regex to cut the edge cases for non-standard versioning examples?

jdhitsolutions commented 1 year ago

We can leave the PR pending for now. I'm really hoping that the Winget team can produce a high-quality PowerShell module that would make this module moot. I'm having discussions with a team leader, hoping to help guide them.