search

jdlorimer / chinese-support-redux

Anki add-on providing support for Chinese study
https://ankiweb.net/shared/info/1128979221
GNU General Public License v3.0
101 stars 50 forks source link

Ruby Jyutping for Cantonese #77

Open p2635 opened 4 years ago

p2635 commented 4 years ago

Is your feature request related to a problem? Please describe. There is already nice support for generating the jyutping pronunciation but it would be good if there could be a ruby version of this.

Describe the solution you'd like As above.

Describe alternatives you've considered Unsure

p2635 commented 4 years ago

Not a super must have and probably down to how many want this enhancement. I can quite easily work around this but just editing the note type such that the pronunciation is below the expression.

image

jdlorimer commented 4 years ago

I've got the unit tests set up for this, but haven't really looked into how easy it might be to fix. I think it's still flagged FIXME in the code, so definitely we'll just leave this open as something that needs to be addressed.

On Sun., 28 Jul. 2019, 11:18 pm Philip Wong, notifications@github.com wrote:

Not a super must have and probably down to how many want this enhancement. I can quite easily work around this but just editing the note type such that the pronunciation is below the expression.

[image: image] https://user-images.githubusercontent.com/4522927/62007553-c0ae8280-b146-11e9-93c1-12972751f1b1.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/luoliyan/chinese-support-redux/issues/77?email_source=notifications&email_token=AF6US7AYSHVQC575DBQENO3QBWPSXA5CNFSM4IHMQXRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD267BVA#issuecomment-515764436, or mute the thread https://github.com/notifications/unsubscribe-auth/AF6US7FHJTUJBYYZQVORZ5DQBWPSXANCNFSM4IHMQXRA .

jdlorimer commented 4 years ago

Turns out that particular word doesn't have Jyutping in the database. I've enabled ruby support for Cantonese now, but it's limited by the available transcription information. I'm looking at incorporating another source for the Jyutping, but it might have to wait a bit.

p2635 commented 4 years ago

Don't worry, @luoliyan . This is probably low priority as the workaround is quite good.

We can monitor the demand on this one.