search

jdorner / node-sapnwrfc

SAP Netweaver RFC SDK bindings for Node.js
MIT License
55 stars 23 forks source link

Do not try to compile under Darwin. #20

Closed seal-ss closed 9 years ago

seal-ss commented 9 years ago

@seal-mis has added another improvement to make development on a Mac much easier. We code on MacBookPro's and clone our source and run npm install on OSX. Then we run Docker containers for unit and integration tests which is Linux based. So with this addition we are able to install your module with the precompiled binaries for Linux and then run it in a Docker container without the need of recompiling it inside the Container.

jdorner commented 9 years ago

To be honest.. I don't get it. If the precompiled binaries get copied to the compiled/4.2.1/... directory (which your CI scripts do), then an npm install doesn't do any harm? Anyway, I'll agree that trying to compile this on Darwin is pretty senseless ;-)

StefanScherer commented 9 years ago

The idea is that the compiled directory is part of a published future version at npmjs.org.

Installing such node-sapnwrfc module with npm install will provide the binaries for Linux and Windows. On OSX the compilation is skipped and on Windows and Linux with the right version of node used also will skip compilation as the binary binding is already there.

With such an installation someone is able to run the own code including his node_modules tree mapped into a Linux Docker container (ok, the container also must contain the sapnwrfc sdk shared libs for Linux, which must be provided in another way).

StefanScherer commented 9 years ago

And yes, npm install looks for that files in the compiled directory. That's why we added the *.node files there.