search

jeanfeydy / geomloss

Geometric loss functions between point clouds, images and volumes
MIT License
599 stars 60 forks source link

'generic_logsumexp' not defined when running code sample #17

Closed cvignac closed 4 years ago

cvignac commented 4 years ago

Hello Jean, the library looks really nice, thank you for your work!

Unfortunately, I don't manage to run the code sample in the index page. I get the following error:

line 73, in keops_lse
    log_conv = generic_logsumexp("( B - (P * " + cost + " ) )",
NameError: name 'generic_logsumexp' is not defined

It happens every time I try to use the multiscale Sinkhorn. However, tensorized versions of Sinkhorn seem to work well, both on CPU and GPU. Has this issue been referenced before?

Thanks

jeanfeydy commented 4 years ago

Hi @cvignac ,

Thanks for your feedback! In all likelihood, this will be fixed by installing the KeOps library. As discussed in the getting started guide, it is a hard dependency for the "online" and "multiscale" backends of SamplesLoss. (I should make the error message more explicit, that's true!)

Best regards, Jean

cvignac commented 4 years ago

I had indeed missed that step, thank you!