search

jeanparpaillon / erlang-dbus

Erlang DBUS implementation (forked from unmaintained erlang-dbus)
Apache License 2.0
52 stars 22 forks source link

Prepare for OTP integration #16

Closed saa closed 8 years ago

saa commented 8 years ago

@jeanparpaillon I have questions. And I want start from this "use OTP-style Makefiles". What do you mean? I look at https://github.com/richcarl/merl/blob/master/Makefile (was include to otp) and need make similar?

saa commented 8 years ago

Also, maybe I can start work on it https://github.com/lizenn/erlang-dbus/issues/8 but in separate branch?

jeanparpaillon commented 8 years ago

That would be great ! You can work on your own fork, and I will integrate in a separate branch your pull requests.

saa commented 8 years ago

Good. You can bit explain about "use OTP-style Makefiles"?

jeanparpaillon commented 8 years ago

OTP applications uses some some makefile libraries / variables / etc (see https://github.com/erlang/otp/tree/maint/make) . erlang-dbus uses erlang.mk.

saa commented 8 years ago

Ah, got it, I thought maybe other things. So will be work in a separate branch.

jeanparpaillon commented 8 years ago

Sure, that kind of feature really deserve a separate branch before merging. Thanks

saa commented 8 years ago

Good, about my proposal. I start it on google docs and link you, ok? In IRC private message?

jeanparpaillon commented 8 years ago

Ok for google docs

saa commented 8 years ago

@jeanparpaillon review please and I need your feedback https://docs.google.com/document/d/1gTjyVzGuUzuDkQ9HF3xM5atPJe-aEE8j02X8lFMcCsk/edit?usp=sharing

jeanparpaillon commented 8 years ago

@saa : done, thanks for this sound proposal. Rationale and obectives looks clear. With a risk management plan it should be perfect.

saa commented 8 years ago

@jeanparpaillon thanks for review. Right now I doing fixes and ping your again and if all is ok I will upload it to gsoc site.

saa commented 8 years ago

@jeanparpaillon updated

jeanparpaillon commented 8 years ago

Ok

saa commented 8 years ago

@jeanparpaillon fixed. All is ok and I can upload it on GSoC site?

jeanparpaillon commented 8 years ago

Go :)

saa commented 8 years ago

@jeanparpaillon Thanks for choose. I see a great work.

jeanparpaillon commented 8 years ago

Congrats. Glad to work with you ! I'm looking forward for your contribs.

jeanparpaillon commented 8 years ago

Let's follow this on https://github.com/lizenn/erlang-dbus/wiki/IntegrationOTP