search

jeckman / YouTube-Downloader

PHP script for downloading videos from youtube; also parsing youtube feed into RSS enclosures for podcatchers
GNU General Public License v2.0
895 stars 474 forks source link

Added support for creation of RSS feeds from YouTube channels and user pages #286

Closed Adrixan closed 6 years ago

Adrixan commented 7 years ago
Art4 commented 7 years ago

Hey 👋 and thank you for your contribution.

Overall there is a 👍 from me for this PR. But I'm not so happy with new Helper class. We moved the methods into the controller so we can made them private and can refactor them in the future without BC breaks.

Because the new FeedController needs some of the methods you should move them into the ControllerAbstract and set them to protected. Can you please do this?

If this was done I will fix the code styling in all classes to PSR-2 and release v0.6. 🍻

Adrixan commented 7 years ago

Thanks for the feedback! I'll see that I have the refactoring done by the end of the weekend. :)

Adrixan commented 7 years ago

All done! :)