jeckman / YouTube-Downloader

PHP script for downloading videos from youtube; also parsing youtube feed into RSS enclosures for podcatchers
GNU General Public License v2.0
895 stars 474 forks source link

Is that possible to use QUIC to download the video ? #292

Closed funglee2k closed 6 years ago

funglee2k commented 6 years ago

Description

[Description of the issue]

Steps to Reproduce

Please include the direct url to the YouTube video.

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior: [What you expect to happen]

Actual behavior: [What actually happens]

Version

Please include the version of YouTube-Downloader you are running. You can get this information from the footer in the web interface.

Additional Information

Any additional information, configuration, server OS and what version of the OS you're running or data that might be necessary to reproduce the issue.

Art4 commented 6 years ago

Create a QUIC client that implements the YoutubeDownloader\Http\Client interface. In the bootstrap.php you can override the default http client by injecting your client into the DIC before the App is created:

// bootstrap.php
$container->set('YoutubeDownloader\Http\Client', function ($c) {
    return new \YourNamespace\Http\QuicClient();
});

return new \YoutubeDownloader\Application\App($container);

A PR for a QUIC client will be much appreciated. 🙂