fix somes 0 bits need test

jeckman / YouTube-Downloader

PHP script for downloading videos from youtube; also parsing youtube feed into RSS enclosures for podcatchers

GNU General Public License v2.0

895 stars 474 forks source link

fix somes 0 bits need test #394

Closed ProjectcoreDevs closed 5 years ago

ProjectcoreDevs commented 5 years ago

jeckman commented 5 years ago

I don't follow the logic here - the code sets $signature at line 179, then at 180 you have an if(!$signature) check - but won't that always be true, because at a minimum $signature at that point will be the string '&sig=' even if there was no value in $sig variable?

I don't see how this adds value - if I'm missing something feel free to reopen