jedimt / hcicollector

12 stars 7 forks source link

SolidFire Grafana graphs all have 0-100 set for percentage fields. Should be 0-1. #20

Closed Snickher closed 5 years ago

Snickher commented 5 years ago

Once all the numbers are pulled and entered using floats instead of integers, all the Grafana graphs for SolidFire metrics are off by a factor of 100. All the graphs that deal with percentages are coded to be between 1-100. The SF API returns numbers between 0 and 1, and in the case of the throttle volume metric at least, can return values over 1 as well to indicate bursting.

Please fix all the Grafana graphs to report percentages correctly.

jedimt commented 5 years ago

I have changed the graphs from "percent" to "percentunit" as per your feedback. Please have a look and let me know if I missed anything.