jedisct1 / rust-bloom-filter

A fast Bloom filter implementation in Rust
BSD 2-Clause "Simplified" License
235 stars 51 forks source link

Split bloom state and configuration into separate structures #8

Closed ketralnis closed 7 years ago

ketralnis commented 7 years ago

This commit got kind of out of hand and in https://github.com/jedisct1/rust-bloom-filter/issues/7 you specifically mentioned minimising invasiveness so I wanted to pause here to see which bits you're interested in before I chop it up into more acceptable commits. I'm aware that this commit can't be merged as-is but I wanted to get the back-and-forth started :)

This does:

I'm totally willing to drop any of those things and of course I'll rearrange the commits so that the history is more reasonable

ketralnis commented 7 years ago

This clearly need to be chopped up :) Closing and moving parts out into their own PRs

jedisct1 commented 7 years ago

Thanks!