search

jeevatkm / ReplyWithHeaderMozilla

Outlook style headers and few goodies for Thunderbird
https://myjeeva.com/replywithheader-mozilla
Mozilla Public License 2.0
46 stars 22 forks source link

Change header separator color to Outlook default #108

Closed cnmicha closed 6 months ago

cnmicha commented 3 years ago

Hi,

how do you think about changing the default value of the preference extensions.replywithheader.header.separator.line.color to #1E1E1E which is the header separator line color of Outlook?

What was the idea behind choosing the current default color (#B5C4DF)?

If you like, I can provide a pull request for this.

Thanks!

jeevatkm commented 3 years ago

@cnmicha When initially developed the RWH add-on that time I took a color code from Outlook. I think the Outlook client still uses that color. I can see with my macOS Outlook client v16.52 (21080801).

May I know where do you see a black color? web version?

anttiisoaho commented 1 year ago

Looks like Outlook has different default styles in Windows vs Mac. While css is used in email sent by O365 Outlook, I simplified styling into html tags without css and ended up with below html snippet. I had 24 hour clock but otherwise regular US English settings. Note how separator line is produced by O365 Outlook client in Windows, with line color E1E1E1. Below snippet is 100% similar than how replying or forwarding with O365 Outlook client in Windows.

<div><div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p style="margin-top:0;font-family:Calibri,sans-serif;font-size:11pt;">
<b>From:</b> Displayname_if_exist &lt;name@email.com&gt;<br>
<b>Sent:</b> Wednesday, October 11, 2023 17:32<br>
<b>To:</b> Displayname_if_exist &lt;name@email.com&gt;<br>
<b>Subject:</b> Email subject line</p>
</div></div>
jeevatkm commented 1 year ago

@anttiisoaho Thanks for providing the HTML string; it is helpful for understanding.

@cnmicha @anttiisoaho I will change the header line default color to #1E1E1E on v3.0.0 onwards; until then, please use the RWH add-on options to change the color.

anttiisoaho commented 1 year ago

@jeevatkm just note the corrrect color value: #E1E1E1 - I believe there was originally typo by @cnmicha. Additional notes:

jeevatkm commented 1 year ago

@anttiisoaho Thanks. I will take care of it.

jeevatkm commented 7 months ago

@cnmicha @anttiisoaho I'm working on the WebExtension version of RWH. The branch is here.

I require a sample string of the following in multiple languages for a Plain Text email.

Reply

On 4/27/24 5:58 PM, Thunderbird Add-ons wrote:

Forward

-------- Forwarded Message --------
Subject: Mozilla Add-on User Rating: ReplyWithHeader
Date: Sun, 28 Apr 2024 00:58:03 -0000
From: Thunderbird Add-ons <nobody@thunderbird.net>
To: jeeva@myjeeva.com
anttiisoaho commented 7 months ago

Plain text example from O365 (US English) if this is what you wanted - there is no difference in reply or forward so this applies to both:

-empty line, cursor blinks here when starting to reply or forward-
-empty line-
-----Original Message-----
From: Displayname_if_exist <name@email.com>
Sent: Tuesday, April 9, 2024 2:08 PM
To: Displayname_if_exist <name@email.com>
Subject: Email subject line
-empty line-
-forwarded or replied email content-
jeevatkm commented 7 months ago

Thanks, @anttiisoaho, for your help.

jeevatkm commented 6 months ago

@anttiisoaho @cnmicha Please see https://github.com/jeevatkm/ReplyWithHeaderMozilla/issues/103#issuecomment-2106526608, can you try it?

anttiisoaho commented 4 months ago

I finally managed to install fresh TB 128.0.1 with RWH 3.0.0 (release version), and have used that now for couple of days. In general looks good but there is also one bug. I also have some comments/suggestions:

In my case I like to keep TB user interface set to my local language (Finnish in my case), but set RWH to en-US to get "standard" written headers into email replies or forwards. I can set RWH locale in its settings, but it resets to TB user interface language at every TB start, which is a bug to my mind.

Other suggestions:

jeevatkm commented 4 months ago

@anttiisoaho I have created the new bug for the locale issue - https://github.com/jeevatkm/ReplyWithHeaderMozilla/issues/155

Regarding other suggestions: It will be challenging because RWH works when the user clicks on Reply/Reply All/Forward, there is a call listening to TB on the compose window show; it composes the email headers (and RWH features). RWH does not process/handle anything after that. I could experiment with it, but I won't be able to commit to it.

The timer functionally operates only on currently selected message and does not affect other email messages.

Introducing multiple disable/enable features could lead to issues and support questions.

RWH v3 has a new option to turn the feature on/off at the mail account level in addition to that timer enable option.

anttiisoaho commented 4 months ago

Thank you. Perhaps option to enable/disable (=visible/not visible) button would be relatively easy to implement into Options UI (?) I'm after simplicity; most users don't need to change anything after extension properly configured, and for users who would like to e.g. use TB default reply/fwd style for some emails, could have button enabled (=visible).

anttiisoaho commented 4 months ago

Perhaps option to enable/disable (=visible/not visible) button would be relatively easy

I thought hiding menu button or making it visible is easy but seems not to be. messenger.messageDisplayAction.disable(); disables it in a way that button is grayed out but not fully hidden. There is obviously another extension which can be used to hide any of the buttons, also RWH, reorder etc.. but would have been nice to have such option "natively" in RWH extension.