Improve Objective-C and Objective-C++ highlighting

jeff-hykin / better-cpp-syntax

💾 The source of VS Code's C++ syntax highlighting

GNU General Public License v3.0

155 stars 30 forks source link

Improve Objective-C and Objective-C++ highlighting #554

Closed DavidGoldman closed 3 years ago

DavidGoldman commented 3 years ago

Highlight in keyword
Improve self/super/_cmd highlighting, previously it would trigger in an @implementation and a few other places
Improve detection of Objective-C method calls, previously it would get mixed up with meta.bracket.square.access

Fixes #550 and fixes #538

jeff-hykin commented 3 years ago

I worked yesterday on modularizing the libraries in this repo (pulled all the JavaScript out, reorganized it, and published it on npm)

I'm going to try to make a separate repo for each language instead of this giant multi-language monorepo. So hopefully that'll be done in the next week or so.

Ideally modifications would be in Ruby (these current changes are fine). So whenever I make the new repo, I'll give a quick demo of how to do that.

DavidGoldman commented 3 years ago

SGTM, just let me know what I should do, thanks

jeff-hykin commented 3 years ago

Will do, and thank you for the contributions and patience!

NSExceptional commented 3 years ago

@jeff-hykin What do you think the timeline on that will be?

VS Code relies on these (as I'm sure you already know) and won't update their own grammars until they're updated here. I'm not in a crazy hurry to use this new grammar, but if you think it might be another few weeks or longer, is there any harm in just merging this now?

jeff-hykin commented 3 years ago

This is a legitimate question, as this repo itself was made precisely because the original maintainers couldn't get changes merged in fast enough (years).

Two things

Yes there is (some) large potential for downside. Adding one bad pattern can totally wreck many peoples highlighting, and they won't know how to fix it
This repo is both an extension and a VS Code upstream source. The extension is "bleeding edge" meaning yes I should merge first, test later and this PR deserves that. However, the VS Code source is the opposite; it can take half a year for changes in this codebase to show up in VS Code even if I merged it today

I can merge the code, and comment on a PR while on the elevator, or waiting for a bus. But it's not going to show up in the extension until I get to my desktop setup with the intention of opening up the codebase, logging into vsce, packaging, and publishing. Which I think is what you're wanting.

NSExceptional commented 3 years ago

Pardon my confusion, but which extension are you referring to? VS Code bundles these grammars into the app itself, right? I can see the files inside the .app

Or is it one of those "built-in extension" type things?

jeff-hykin commented 3 years ago

People with the extension are beta testers, after changes have been beta tested for a while without major problems, they get merged into VS code official. If I need to accelerate or undo something, I @ some people at Microsoft and they can make manual changes. It's not a built in extension (not like how Atom does it)

The extension is at the top of the readme.md https://marketplace.visualstudio.com/items?itemName=jeff-hykin.better-cpp-syntax Right now the C languages are bundled together, but I want to break them up because people like you and DavidGoldman probably know a lot more about Objective C than I do. The only reason they're together in the first place is because of legacy code.

NSExceptional commented 3 years ago

Ohhh I see, gotcha.

Do you ping someone at Microsoft or open a PR whenever you decide the beta test for a particular change is over?

jeff-hykin commented 3 years ago

Do you ping someone at Microsoft or open a PR whenever you decide the beta test for a particular change is over?

I normally only ping them if theres a critical bug that got fixed, otherwise they test and pull in updates automatically over time.

jeff-hykin commented 3 years ago

@DavidGoldman Alright, that was a little longer than expected but I finished overhauling this repo. It has now been properly broken up into 4 repos.

Now it should be easier to get stuff merged in, and the codebase should be easier to understand/fork/run. There really hasn't been any work done on Objective C/C++ since we seperated it from the C++ syntax several years ago so I'm sure lots of improvements are possible.