`function.definition` changes to `function.call` if a newline is inserted after the return type

[a-stewart]

Consider the following code:

bool test1(int a) {
    return true;
}

bool
test2(int a) {
    return true;
}

Using inspect tokens and scopes, we see that test1 is defined as a entity.name.function.definition.

However, with the added line break, test2 is defined as a entity.name.function.call.

This is fine in the default VS Code theme, since these are coloured the same, however, with themes that differentiate, it results in the syntax highlighting looking off.

To reproduce the above, add the following to settings.json:

  "editor.tokenColorCustomizations": {
    "textMateRules": [
      {
        "scope": ["entity.name.function.definition.cpp"],
        "settings": {
          "fontStyle": "bold underline",
          "foreground": "#8f224c",
        }
      }
    ]
  },