Pull request - Githubissues

jeff-hykin / better-shell-syntax

💾 📦 ♻️ An improvement to the shell syntax for VS Code

MIT License

52 stars 4 forks source link

Pull request #2

Closed derkallevombau closed 3 years ago

derkallevombau commented 4 years ago

Sorry, I just realised that it was a bad idea to create the PR from master, and since you can't change the source branch, I have to create a new PR and close the previous one.

jeff-hykin commented 4 years ago

This is looking good. It'll take me some time to review it, but the rvalue and generator functions look like a good approach. The sed changes are still broken though.