search

jeffhain / jafama

A (Strict)FastMath class with 1e-15ish accuracy.
80 stars 12 forks source link

USE_JDK_MATH for round? #1

Closed kno10 closed 7 years ago

jeffhain commented 7 years ago

Hi, and thanks for the proposal, but I deliberately didn't do that, because I want delegating to JDK methods to only provide at least as accurate results, and JDK round() methods are bugged in some supported Java versions, cf. the bug ids in my Javadoc.

kno10 commented 7 years ago

Ok, I had expected that. I suggest then to add an explicit comment why this is not delegated.

jeffhain commented 7 years ago

That was a bit implied by the comments about the bugs in the Javadoc, but I agree that a more precise and properly located comment in the code wouldn't hurt. I'll take care of this and maybe other upgrades the next time I push some feature (as you can see I don't like to spam the repo with commits ;).