search

jeffreytse / jekyll-spaceship

🚀 A Jekyll plugin to provide powerful supports for table, mathjax, plantuml, mermaid, emoji, video, audio, youtube, vimeo, dailymotion, soundcloud, spotify, etc.
MIT License
626 stars 67 forks source link

support gemoji 4.0.0 #85

Open casperdcl opened 1 year ago

casperdcl commented 1 year ago

vis. https://github.com/jekyll/jemoji/issues/122

See https://github.com/github/gemoji/releases/tag/v4.0.0.pre0 for breaking changes.

ashmaroli commented 1 year ago

For anyone planning on submitting a pull request: you need not drop support for Gemoji v3 for backwards compatibility. Relaxing the constraint to allow Gemoji v4 should suffice.

casperdcl commented 1 year ago

yes, >=3, <5 is probably safest :)

Freed-Wu commented 1 year ago

Any progress about this issue? @jeffreytse