jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
1.97k stars 77 forks source link

Feishin does not log out and log in when changing username in server #618

Open thebiblelover7 opened 1 month ago

thebiblelover7 commented 1 month ago

Read below comment....

Expected Behavior

When I favorite a track in the UI, I should be able to see it when filtering by favorites and a "favorite" icon should show by the track even after refresh.

Current Behavior

Currently, when I favorite a track, Feishin shows a favorite icon by it. Navidrome also understands it and favorites the track successfully (seen in the Navidrome Web UI), but when I refresh Feishin, my favorite track is not favorited anymore (in Feishin).

The favorites do not show up in the GUI at all...

Feishin:

Screenshot 2024-05-16 at 8 20 24 PM

Navidrome:

Screenshot 2024-05-16 at 8 20 45 PM

Steps to Reproduce

https://github.com/jeffvli/feishin/assets/61815862/15cdc3b9-6ae9-409f-b5f2-960cafe61a72

(that "glitch" was a page refresh)

Possible Solution

No response

Context

No response

Application version

v0.7.1

Operating System and version

MacOS 13.6.3

Server and Version

Navidrome v0.52.0

Node Version (if developing locally)

No response

thebiblelover7 commented 1 month ago

Okay, correction... This only happens when you change the username without logging out. It seems that Feishin keeps the data for the old user instead of using the new user's data... so when the new user changes something, Feishin doesn't see that change in the old user's account.

What solved my problem was logging in and out instead of changing the username. Maybe this should be another issue. It would be great if Feishin would "log out" when changing the username of the user.