jeffvli / sonixd

A full-featured Subsonic/Jellyfin compatible desktop music player
GNU General Public License v3.0
1.87k stars 73 forks source link

Add Ctrl+Q keyboard short for Linux #355

Closed buckmelanoma closed 2 years ago

buckmelanoma commented 2 years ago

KDE and GNOME both use Ctrl+Q as a keyboard shortcut to quit the application. This patch adds that shortcut if Linux is detected as the OS.

jeffvli commented 2 years ago

Is the Ctrl + Q shortcut used on all desktop environments (besides KDE/GNOME)? If not, having the blanket linux check for the shortcut may conflict with other commands.

buckmelanoma commented 2 years ago

It's used on most of the popular DEs. Just from some quick research, this is a list of ctrl-q supporting Linux DEs:

Xfce(thunar) Lxqt(pcman-fm, lxqt-config, lxqt-archiver) Lxde(pcman-fm, lxmusic) Cinnamon(nemo)

jeffvli commented 2 years ago

From some additional research it seems as though the CTRL + Q shortcut isn't a global shortcut, but rather one that is set within some applications? CTRL +Q may also be a common shortcut used for media keys, so it may be better for the user to use OS shortcuts or other tools to control closing applications.

buckmelanoma commented 2 years ago

CTRL + Q shortcut isn't a global shortcut, but rather one that is set within some applications

That's been my experience too. Closing this out.