search

jekyll / classifier-reborn

A general classifier module to allow Bayesian and other types of classifications. A fork of cardmagic/classifier.
https://jekyll.github.io/classifier-reborn/
GNU Lesser General Public License v2.1
554 stars 110 forks source link

Add support to reset trained classifiers to their initial state #143

Closed ibnesayeed closed 7 years ago

ibnesayeed commented 7 years ago

I was preserving stopwords to restore on test teardown. However, if the Redis connection fails then the old stopwords were not available to restore. Changing order so that stopwords are cached before Redis connection fails, solved the issue.

ibnesayeed commented 7 years ago

Closed and reopened to trigger CI builds because some builds are failing due to Travis issue.

ibnesayeed commented 7 years ago

Finally, all the builds passed. It's safe and desired to be merged now.

ibnesayeed commented 7 years ago

Please don't merge it yet. I am pushing some more changes in it.

Ch4s3 commented 7 years ago

Sounds good

ibnesayeed commented 7 years ago

This is done, please go ahead and merge it unless you have any code reviews.

ibnesayeed commented 7 years ago

Marking it done from my end.

ibnesayeed commented 7 years ago

@Ch4s3, I have resolved conflicts and it is ready to merge now.

ibnesayeed commented 7 years ago

@Ch4s3 is there anything blocking here in getting it merged? I was thinking of finalizing some other changes after my pending PRs are merged. I wanted to try to avoid dealing with multiple branches, that's why waiting everything to be merged.

Ch4s3 commented 7 years ago

@ibnesayeed sorry, I was taking some time off from open source stuff for health reasons. It looks good!