jellyfin-archive / jellyfin-android-original

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
272 stars 65 forks source link

Remove broken profile #304

Closed JustAMan closed 4 years ago

JustAMan commented 4 years ago

Most likely it was valid when the app came bundled with libvlc, but it is valid no more.

The way it was handled by server was the following:

  1. Okay, profile has no VideoCodec, assign null (JSON behaviour)
  2. Okay, we found a matching container and a matching audio codec, and we interpret null as "any video codec"
  3. Playback with black screen (only audio) happens

Looking through the history I see this profile in the very first version of jellyfin-android, so I think it was there to address the fact that libvlc (which was used in the early days) could have played any video codec. This is no longer true.