search

jellyfin-archive / jellyfin-android-original

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
272 stars 65 forks source link

Embedded mkv subtitles won't work on Android. #307

Closed PedroBarcha closed 4 years ago

PedroBarcha commented 4 years ago

ASS subtitles don't work on my phone. SRT do work, however. As it might be helpful to mention, I was having the same issue in the web interface for Jellyfin 10.5.2. It has been fixed on 10.5.3: https://github.com/jellyfin/jellyfin/pull/2653

irredentist commented 4 years ago

Possible duplicate of issue 258? https://github.com/jellyfin/jellyfin-android/issues/258

ghost commented 4 years ago

Embedded ASS subtitles have been broken since 0.9.9 on Android. Now 0.9.10 has been commited in "package.json" but both the release and git tag have been removed from the project: what is going on?

For the time being i am building my own 0.9.8 apk locally with custom modification and ship it to all my devices manually, which is kind of annoying.

irredentist commented 4 years ago

@willymilkytron would you mind sharing your apk? I just want to be able to watch my shows haha.

ghost commented 4 years ago

@irredentist https://github.com/jellyfin/jellyfin-android/releases/tag/v0.9.8

Artiume commented 4 years ago

We're working on a new android release which will support ass subs properly.

xangelix commented 4 years ago

@irredentist It looks like this issue will be fixed soon but I've been using the Jellyfin AndroidTV app in the meantime on a phone. It's a little weird controlling it with touch, but it works well enough and doesn't have this issue or another issue I'm having with the web version on mobile.

dkanada commented 4 years ago

If you want to test our update now you can visit this link and install the debug version.

xangelix commented 4 years ago

Unfortunately I tried that exact build about an hour ago before trying the AndroidTV app. The debug version you've linked installs successfully, but crashes on startup for me. (Android 10, Pixel 2 XL) I tried it right now again in case it was a different build I tapped on, but same result. I'm not familiar with android development but if there's any easy way I could provide some logs then I would be glad to.

dkanada commented 4 years ago

Looks like we have a runtime error on the master branch! When I get around to fixing that in the next few days, you'll be able to download the latest debug version from there and test the change.

Cyan101 commented 4 years ago

Just the latest run in the azure devops?

dkanada commented 4 years ago

We still have to update the tag for the web client I think.

Cyan101 commented 4 years ago

Alright, well if it helps I just tested the latest debug and now my ASS subtitles are working in the app

On Tue, 21 Apr. 2020, 12:36 pm dkanada, notifications@github.com wrote:

We still have to update the tag for the web client I think.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jellyfin/jellyfin-android/issues/307#issuecomment-616946753, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVQY3TUBADEM5MBVHFOSJLRNUPEBANCNFSM4MEJBP6A .

idaxx commented 4 years ago

We have any ETA for this fix? I tried debug apk but it closes before the start

dkanada commented 4 years ago

I'll be pushing an update in the next few days for Google Play and our repository. This will also be the first version to show up on F-Droid.

idaxx commented 4 years ago

SSA subtitles still dont show on mkv after release of last version Edit: It takes few seconds to start subtitles. Good job!

PedroBarcha commented 4 years ago

Working like a charm, thanks!