search

jellyfin-archive / jellyfin-android-original

Android Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
272 stars 65 forks source link

Reduce Noto footprint #312

Closed ferferga closed 4 years ago

ferferga commented 4 years ago

This PR is a followup of jellyfin/jellyfin#2871 and jellyfin/jellyfin-web#1087, so see them before for a better explanation.

This PR aims at using the packaged version of the new jellyfin-noto repo structure. for Android. This PR only makes sense after merging the web PR, because otherwise we would be bundling fonts two times in the apk file.

Problems I'm new to Cordova development so I have no idea why this happens, but what I do simply doesn't work: in the resulting apk file, the files are not present in the assets/css directory of the web source. As long as this is solved, everything should be fine, so I need the help of the experienced people 😊.

Fixed in latest commit! I was copying to the wrong location

Testing

As with my other PRs, checkout font-serve branch. Files won't be copied to the final apk file anyway.

dkanada commented 4 years ago

I'll close this since @ferferga mentioned only web will need changes now to fix the install size.