jellyfin / Swiftfin

Native Jellyfin Client for iOS and tvOS
Mozilla Public License 2.0
2.5k stars 272 forks source link

Jellyfin doesn't show library because its type is "nil" #1245

Open FrankreedX opened 6 days ago

FrankreedX commented 6 days ago

Describe the bug

I admit that this is partly my fault. When I set up my library, I plan on putting both movies and tv shows in the same library because I don't care about the multi-library workflow. I left the "type" field blank. Now when I use Swiftfin, the "Media" tab would not show my library, instead just showing an empty "Favorite" collection.

Screenshot 2024-09-23 at 9 31 16 PM

I dug into the code a bit and see that only ["boxsets", "folders", "movies", "tvshows", "livetv"] are supported. I have a couple of issues with this: First is people like me who didn't know better and set up their libraries wrong. As the web client handles this correctly, I didn't realize it was a problem until using the app. And there's no way to change the type of library after the fact. (https://github.com/jellyfin/jellyfin/issues/10570) Secondly, correct me if I'm wrong but I don't see how the app handles these types of libraries differently from each other, maybe just displaying a different string here and there. Personally I think that media (shows, movies, etc.) should be treated differently, but the type of library should not be treated differently at all.

Application version

1.2 (4)

Where did you install the app from?

TestFlight

Device information

iPhone 11 Pro

OS version

iOS 18.0

Jellyfin server version

10.9.11

FrankreedX commented 6 days ago

When I remove the line that exclude views that didn't fit the listed types, my library shows up and works as expected

LePips commented 5 days ago

We only currently support movies and tv shows, which is why we need to filter based on the collection type, it has nothing to do with how they differ. The web "works" because it doesn't have to filter.

However, this may be the issue for #1100 but will have to look again after we update our SDK to the 10.9 generation.

FrankreedX commented 5 days ago

I am aware of the app only supporting movies and tvshows, I just wish that it filters the actual media instead of entire collection, because I only have movies and tv shows on my server.