search

jellyfin / jellyfin-helm

Kubernetes Helm Chart for Jellyfin
GNU General Public License v2.0
25 stars 18 forks source link

Update chart to have imagePullSecrets option. #36

Closed j14s closed 2 weeks ago

j14s commented 2 weeks ago

Allow hosted container on a registry with authentication(e.g., a caching proxy registry). Chart version bumped to 1.30.1.

j14s commented 2 weeks ago

Tested this for my deploy and is working to Helm/K8S standards for imagePullSecrets.

If you need any changes to how I submitted this PR just let me know.

Supporterino commented 2 weeks ago

@j14s hey quick feedback you shouldn't touch the version inside Chart.yaml since it gets auto bumped if your commits follow conventional commit guidelines

j14s commented 2 weeks ago

Updated. Hrmm, but I guess you took it.