jellyfin / jellyfin-mpv-shim

MPV Cast Client for Jellyfin
Other
1.66k stars 95 forks source link

External MPV in flatpak #417

Open lowne opened 2 months ago

lowne commented 2 months ago

Regarding the numerous issues on running external mpv from flatpak - eg #375 #354 #329 #80 and #76 (indirectly) - is there any reason why flatpak-spawn--host /path/to/mpv can't be used internally? This can't be done by the end user because mpv_ext_path is passed as is and ultimately used as the binary path (as opposed to split into a List[str] then further extended with the other args).

This will need:

or alternatively, allow it from conf.json; passing a list by ' '.split(mpv_ext_path) will most likely break on windows so maybe add an alternative mpv_ext_cmd field:

  "mpv_ext": true,
  "mpv_ext_path": "",
  "mpv_ext_cmd": ["flatpak-spawn", "--host", "/path/to/mpv"],