jellyfin / jellyfin-plugin-opensubtitles

https://jellyfin.org
GNU General Public License v3.0
121 stars 26 forks source link

OpenSubtitles downloader only returns Bad Request #66

Closed InavL closed 2 years ago

InavL commented 2 years ago

Jellyfin: 10.7.7 OpenSubtitles plugin: 11.0.0 OS: DSM7 on a DS220+ Using the built in reverse proxy in DSM, not sure if that contributes to it instead of manually setting up nginx.

When the activity is triggered it just clogs the logs with messages identical to this:

Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - ""

Login and API keys all look well. Tried with both dev and non-dev key.

MBR-0001 commented 2 years ago

It appears that OpenSubtitles changed something in their API, I've contacted them for clarification

JRPGod commented 2 years ago

@MBR-0001 Any response from them?

MBR-0001 commented 2 years ago

No 😕 They usually respond within 1-2 work days so they are either really busy or my email somehow didn't reach them...

MBR-0001 commented 2 years ago

This shouldn't be happening anymore, can you check and close the issue if it's fixed? EDIT: The API changed a bit so PR #67 needs to be merged for this to be fixed

opensubtitles commented 2 years ago

hi guys, you can contact us on Slack, or via our contact form on website. It is true we are changing some stuff here and there and sorry for breaking it for few days.

myfingerhurt commented 2 years ago

[12:10:53] [INF] [1] Main: Jellyfin version: 10.7.7

Is this the same issue?

[13:53:09] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:09] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:25] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:25] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:25] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:44] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:44] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:45] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:47] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:48] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:49] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
MBR-0001 commented 2 years ago

[12:10:53] [INF] [1] Main: Jellyfin version: 10.7.7

Is this the same issue?

[13:53:09] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:09] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:25] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:25] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:25] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:44] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:44] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:45] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:47] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:48] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}
[13:53:49] [ERR] [17] Jellyfin.Plugin.OpenSubtitles.OpenSubtitleDownloader: Invalid response: BadRequest - {"errors":["Query is too short"],"status":400}

No it is not, can you enable debugging, run the subtitle task again and open a new issue with the detailed logs?